|
|
Post by lantzelot on Apr 11, 2021 18:09:11 GMT
ok, there is a mix of many different file formats in demobase 64. .zip, .T64, .D64, .D64.gz etc. The game manager assumes everyhing ends with .zip if they are zipped...
I will go through it and fix so that imports from demobase works better.
|
|
|
|
Post by sjakie43 on Apr 11, 2021 18:18:55 GMT
Thank you Lantz , Appreciated  |
|
|
|
Post by lantzelot on Apr 11, 2021 21:53:40 GMT
New release: 1.7.1bugfix: Import from a gamebase db handles files in different formats better -gz files are not zipped again -prg files are not zipped at all since VICE does not handle it -rar files are handled in the same way as zip files (picking the first entry). Please try this out with demobase 64, it should work much better. I might have missed some file formats, please let me know if there are demos that doesn't work. |
|
|
|
Post by sjakie43 on Apr 12, 2021 7:47:05 GMT
Thanx Lantz, i will check it out |
|
|
|
Post by sjakie43 on Apr 12, 2021 8:00:02 GMT
So far loading goes much better, only....... no sound in Winvice? 
Ehrm,,,,,,Warp speed was still on,,,, my bad  it's ok now |
|
|
|
Post by sjakie43 on Apr 12, 2021 9:45:48 GMT
i have tried to import the whole Demobase 64.
|
|
|
|
Post by vic2020ian on Apr 12, 2021 11:33:41 GMT
i have tried to import the whole Demobase 64.
Your log is a Gamebase import not Demobase? Did you mean - the new version tweaked for Demobase has broken Gamebase import? |
|
|
|
Post by sjakie43 on Apr 12, 2021 13:46:14 GMT
Demobase is made with Gamebase yes
This demobase has 47380 entries of which 644 have no file = 46756 entries 
But in GameManager is have 39307 entries(minus the 7 lines of text already in GameManager would be 39300 Demo entries)
|
|
|
|
Post by vic2020ian on Apr 12, 2021 15:44:47 GMT
Could be you hit a limit? suspicious 39300 imports exactly.
Is is possible the 8080 less 644 have some other file format?
Can you spot the first few first missing ones in say A and see if they are somehow different?
|
|
|
|
Post by sjakie43 on Apr 12, 2021 18:02:13 GMT
i found a few in the A section that are missing but they are no different.D64 and prg files......  |
|
|
|
Post by sjakie43 on Apr 12, 2021 19:46:00 GMT
i also noticed just now that of the 900+ batches only 786 are done ,the importing stops and you can close the import window.now it says 39165 demos.
So when trying 2 times to import i get 2 slighty different results in number of demos imported.
|
|
|
|
Post by lantzelot on Apr 12, 2021 22:11:51 GMT
i also noticed just now that of the 900+ batches only 786 are done ,the importing stops and you can close the import window.now it says 39165 demos.
So when trying 2 times to import i get 2 slighty different results in number of demos imported.
by me the same Yes, I also noticed that the batch calculation seems a bit off, I will look into that. I also found a problem where entries are skipped during import if they have the exact same name but differs in casing, e.g. "Always on my Mind" and "Always on My Mind". Demobase 64 have many entries with the same name, there are some problems there during import. I will try to figure it out tomorrow. |
|
|
|
Post by lantzelot on Apr 14, 2021 21:53:54 GMT
I think I have fixed the problems now with the import from demobase 64. New release: 1.7.2A number of bug fixes for the gamebase importer function: - Games with same name but different case is not skipped during gamebase import
- Not all files are skipped if one is corrupt or missing (e.g. screenshot) during import.
- Corrected wrong chunk calculation when importing large amounts of games/demos from gamebase
- Files added to the temp directory during import gets an index to make them unique. Unzipped files are added to a subdirectory named after the zip file to avoid name clashes.
- Sets ERROR as default level for logger to avoid spamming the log file during gb imports. Only errors are written to the pcusb.log file now.
- Removes "alwaysOnTop" property for dialogs so that they are not on top of other applications in windows.
I identified some problems when importing large sets of games/demos from a gamebase database. Depending on the chunks it reads it was possible that some games where skipped. This also applies for games imported from gb64 or gamebase vic-20. I have tested to import all demos starting with "a" and "b" and the number of entries are as expected in the game manager after completion. I also imported the entire gamebase vic-20 and that was also correct. Please have a try! |
|
|
|
Post by vic2020ian on Apr 15, 2021 7:02:43 GMT
Many thanks Lance. Impressive stuff.
|
|
|
|
Post by sjakie43 on Apr 15, 2021 8:31:05 GMT
Thank you Lantz, i will check it out |
|
|
|
Post by sjakie43 on Apr 15, 2021 10:02:08 GMT
The import stopped at batch 786 of 935 ----------------------------------------------------------------------------------------------------------
Could not scale and store screenshot
javax.imageio.IIOException: Error reading PNG metadata
at java.desktop/com.sun.imageio.plugins.png.PNGImageReader.readMetadata(PNGImageReader.java:902)
at java.desktop/com.sun.imageio.plugins.png.PNGImageReader.readImage(PNGImageReader.java:1405)
at java.desktop/com.sun.imageio.plugins.png.PNGImageReader.read(PNGImageReader.java:1820)
at java.desktop/javax.imageio.ImageIO.read(ImageIO.java:1468)
at java.desktop/javax.imageio.ImageIO.read(ImageIO.java:1315)
at se.lantz.util.FileManager.scaleScreenshotImageAndSave(FileManager.java:974)
at se.lantz.manager.ImportManager.copyFiles(ImportManager.java:626)
at se.lantz.manager.ImportManager.lambda$copyFiles$2(ImportManager.java:525)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1624)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:658)
at se.lantz.manager.ImportManager.copyFiles(ImportManager.java:525)
at se.lantz.gui.imports.GamebaseImportWorker.doInBackground(GamebaseImportWorker.java:78)
at se.lantz.gui.imports.GamebaseImportWorker.doInBackground(GamebaseImportWorker.java:10)
at java.desktop/javax.swing.SwingWorker$1.call(SwingWorker.java:304)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.desktop/javax.swing.SwingWorker.run(SwingWorker.java:343)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at java.base/java.lang.Thread.run(Thread.java:832)
Caused by: java.io.EOFException
at java.desktop/javax.imageio.stream.ImageInputStreamImpl.readInt(ImageInputStreamImpl.java:251)
at java.desktop/com.sun.imageio.plugins.png.PNGImageReader.readMetadata(PNGImageReader.java:750)
... 18 more
-------------------------------------------------------------------------------------------------
Just like last time 39307 demos imported so no change .....
Demobase64 has 47380 entries of which 644 have no file so it should be more ....
|
|
|
|
Post by lantzelot on Apr 15, 2021 20:03:32 GMT
The import stopped at batch 786 of 935 ----------------------------------------------------------------------------------------------------------
Could not scale and store screenshot
javax.imageio.IIOException: Error reading PNG metadata
at java.desktop/com.sun.imageio.plugins.png.PNGImageReader.readMetadata(PNGImageReader.java:902)
at java.desktop/com.sun.imageio.plugins.png.PNGImageReader.readImage(PNGImageReader.java:1405)
at java.desktop/com.sun.imageio.plugins.png.PNGImageReader.read(PNGImageReader.java:1820)
at java.desktop/javax.imageio.ImageIO.read(ImageIO.java:1468)
at java.desktop/javax.imageio.ImageIO.read(ImageIO.java:1315)
at se.lantz.util.FileManager.scaleScreenshotImageAndSave(FileManager.java:974)
at se.lantz.manager.ImportManager.copyFiles(ImportManager.java:626)
at se.lantz.manager.ImportManager.lambda$copyFiles$2(ImportManager.java:525)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1624)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:658)
at se.lantz.manager.ImportManager.copyFiles(ImportManager.java:525)
at se.lantz.gui.imports.GamebaseImportWorker.doInBackground(GamebaseImportWorker.java:78)
at se.lantz.gui.imports.GamebaseImportWorker.doInBackground(GamebaseImportWorker.java:10)
at java.desktop/javax.swing.SwingWorker$1.call(SwingWorker.java:304)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.desktop/javax.swing.SwingWorker.run(SwingWorker.java:343)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at java.base/java.lang.Thread.run(Thread.java:832)
Caused by: java.io.EOFException
at java.desktop/javax.imageio.stream.ImageInputStreamImpl.readInt(ImageInputStreamImpl.java:251)
at java.desktop/com.sun.imageio.plugins.png.PNGImageReader.readMetadata(PNGImageReader.java:750)
... 18 more
-------------------------------------------------------------------------------------------------
Just like last time 39307 demos imported so no change .....
Demobase64 has 47380 entries of which 644 have no file so it should be more ....
Ok, I guess I need to run the entire import myself... something unexpected happens. Before I do that, could you perhaps attach the pcusb.log file as-is here? I don't think this error causes the import to stop. The attached rtf seems to be from a vic-20 import? |
|
|
|
Post by lantzelot on Apr 15, 2021 20:12:36 GMT
I need the file named "pcusb.log" in the root directory of the game manager, there must be more errors logged in that file. |
|
|
|
Post by lantzelot on Apr 15, 2021 20:31:30 GMT
Perfect, I found the problem: Caused by: java.nio.file.InvalidPathException: Illegal char <|> at index 14: ./covers/INTRO|FREEZE-cover.pngThe "|" in the path was not handled correctly for this file, which caused the import to stop. I will fix it and then run the entire import to verify that it works. Thanks for the feedback! |
|
|
|
Post by sjakie43 on Apr 15, 2021 21:31:22 GMT
I was just taking a nap........ 
Nice that you found it  |
|
|
|
Post by lantzelot on Apr 16, 2021 18:02:45 GMT
New release: 1.7.3Bug fixes: - Handles games where a "|" is part of the name when importing from gamebase.
- Better error handling for corrupted screenshots during gamebase import.
Now the entire demobase 64 can be imported without problems (the errors comes from missing/corrupted screenshots and two game files that could not be copied for some reason):
  |
|
|
|
Post by sjakie43 on Apr 16, 2021 18:18:44 GMT
Looks Good Lantz, i will check it asap , thank you |
|
|
|
Post by sjakie43 on Apr 16, 2021 18:27:17 GMT
What i do have i a request Lantz.
I noticed some sid options in your Game manager and i was hoping that you are willing to add the Options for stereo sid?($DE00 is the most used option as far as i know)
Let me know what you think please .
I am preparing some D64 Sidplayer disks(compilations) and i would also like to prepare some Disks with stereo sid)
|
|
|
|
Post by sjakie43 on Apr 17, 2021 8:43:56 GMT
Import looks much better now Lantz, same results as yours |
|
|
|
Post by oocozyoo on Apr 19, 2021 21:07:00 GMT
Ive got a game which uses the full stop as a direction on the keyboard but cannot find that option in the pull down????to modify the joystick options.
, co (colon) is left and . (fullstop) is right theres an option for the , co but not the fullstop.
|
|
|
|
Post by lantzelot on Apr 20, 2021 7:05:01 GMT
Ive got a game which uses the full stop as a direction on the keyboard but cannot find that option in the pull down????to modify the joystick options. , co (colon) is left and . (fullstop) is right theres an option for the , co but not the fullstop. The keys you can select are the keys that TheC64 supports. In the The64 Manual, page 67, all supported keys are listed. Sadly there seems to be no support for ".". so I cannot add it to the game manager. |
|
|
|
Post by sjakie43 on Apr 20, 2021 7:22:46 GMT
Hi Lantz,
Have you given my request a thought ?
|
|
|
|
Post by lantzelot on Apr 20, 2021 8:14:04 GMT
What i do have i a request Lantz.
I noticed some sid options in your Game manager and i was hoping that you are willing to add the Options for stereo sid?($DE00 is the most used option as far as i know)
Let me know what you think please .
I am preparing some D64 Sidplayer disks(compilations) and i would also like to prepare some Disks with stereo sid)
I'm not familiar with stereo sid... How does that work, and is that supported by the carousel in some way? Do you have some more information about it? |
|
|
|
Post by sjakie43 on Apr 20, 2021 8:27:07 GMT
I'm no tech but in Vice(2.4) you can activate a second SID chip and choose a memory adress $DE00 is the most commonly used.
That means that the second sid uses his own memory space and doesnt interf with the standard sid chip,,,, maybe jj0 can help ?
|
|
|
|
Post by jj0 on Apr 22, 2021 6:25:40 GMT
I'm no tech but in Vice(2.4) you can activate a second SID chip and choose a memory adress $DE00 is the most commonly used.
That means that the second sid uses his own memory space and doesnt interf with the standard sid chip,,,, maybe jj0 can help ?
For activating this (if possible) in the Carousel v1.0.5 gurce might be able to help. But you could also try the settings in the full-blown VICE, see if it works there. |
|
it's ok now 
